Implement native method for PresentFileExternally in MacOS
#6365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: PercyDan <50285552+PercyDan54@users.noreply.github.com>
mac's native method will not open file if file is not exists in this case, we fallback to `OpenFileExternally`, so that we can show the folder and without highlight Co-Authored-By: PercyDan <50285552+PercyDan54@users.noreply.github.com>
peppy
reviewed
Aug 26, 2024
peppy
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apple doc: https://developer.apple.com/documentation/appkit/nsworkspace/1524399-selectfile
This API only overrides PresentFileExternally as it can only highlight the incoming file in its parent directory.
We check if the file exists first (see c1fd956), because if the file doesn't exist, the API won't do anything so we will fall back to
OpenFileExternally, which then usesopenUsingShellExecute.